[openib-general] [PATCH] remove unnecessary include

James Lentini jlentini at netapp.com
Mon Aug 28 11:20:56 PDT 2006



On Mon, 28 Aug 2006, Roland Dreier wrote:

>     > -#include <linux/init.h>
> 
> that file declares a function as __devinit, so <linux/init.h> is
> definitely needed.  What is pulling it in implicitly?

Here's the include sequence:

mthca_mcg.c includes
 mthca_cmd.h includes
  rdma/ib_verbs.h includes
   linux/device.h includes
    linux/module.h includes
     linux/moduleparam.h includes
      linux/init.h

Given how many levels down this is, I'm going to change my mind. I 
think the current explicit include is better than what I suggested.




More information about the general mailing list