[openib-general] [PATCH v2] IB_mthca HCA profile module parameters

[Moni Shoua]

Roland Dreier wrote:
> OK, getting better, but still not there:
> 
>  > +	if (mthca_is_memfree(mdev)) {
>  > +		mthca_check_profile_and_warn(num_udav,default_profile.num_udav,
>  > +							 MTHCA_DEFAULT_NUM_UDAV);
>  > +		mthca_check_profile_and_warn(fmr_reserved_mtts,default_profile.fmr_reserved_mtts,
>  > +							 MTHCA_DEFAULT_NUM_RESERVED_MTTS);
> 
> fmr_reserved_mtts is actually only used for NON-memfree HCAs.
> 
> Also, coding style is spaces after commas, so you should do
> 
> 	foo(x, y, z);
> 
> instead of
> 
> 	foo(x,y,z);
> 
> I think it will be easier if I just try to fix this patch up myself
> instead of iterating like this...
> 
Hi,
It is fine with me if you make the necessary changes in this patch to make it acceptable.
I would appericaite if you send publish it after that to let me learn about the changes you made.
thanks and sorry for the delay in replying.

MoniS