[openib-general] [PATCH v2 1/7] IB/core - Add DMA mapping functions to allow device drivers to interpose

Ralph Campbell ralph.campbell at qlogic.com
Tue Dec 5 13:58:16 PST 2006


On Fri, 2006-12-01 at 15:15 -0800, Roland Dreier wrote:
> Oh yeah, one other thing...
> 
> could you respin this so that all the new dma_xxx wrappers go into a
> new file like <rdma/ib_dma_mapping.h> (and include that from
> <rdma/ib_verbs.h>)?  ib_verbs.h is already too big I think.

I can move the definition for struct ib_dma_mapping_ops to a
separate header file but if I move the inline functions
and include the header file at the top of ib_verbs.h,
then the struct ib_device is not defined and the compiler
complains.  I could put the #include <rdma/ib_dma_mapping.h>
after the definition of struct ib_device but I'm not sure
how acceptable that is for coding style.

Do you still want me to make this change?





More information about the general mailing list