[openib-general] [PATCH v2 1/7] IB/core - Add DMA mapping functions to allow device drivers to interpose

[Ralph Campbell]

On Tue, 2006-12-05 at 13:28 -0800, Roland Dreier wrote:
>  > This structure misses some functions which are members of  struct
>  > dma_mapping_ops.
> 
> I don't think we have to wrap every possible function if no IB
> consumer uses it.
> 
>  > The most notable miss to me is dma_alloc/free_coherent, please note
>  > that an IB consumer can call dma_alloc_coherent and place the resulted
>  > dma_addr_t within an SGE provided to ibv_post_send/recv, see the RDS
>  > code doing the allocation at ib_cm.c :: rds_ib_setup_qp and the direct
>  > usage of the dma_addr_t at ib_recv :: rds_ib_recv_init_ring under
>  > under http://oss.oracle.com/projects/rds/src/trunk/linux/net/rds
> 
> Given that some use of the dma_alloc_coherent interface exists though,
> I do think it makes sense to wrap it.  So Ralph can you please add
> that to your resubmission too (in addition to fixing the sync_single
> issue).

OK.

> Any other issues Or?  (BTW thanks for helping review this and pointing
> out some good issues)