[openib-general] (no subject)

[Or Gerlitz]

On 12/14/06, Roland Dreier <rdreier at cisco.com> wrote:
>> mmm, I understand all the comments raised during the review were fixed
>> in the V3 post below, and now you say its both wrong and ugly... for
>> example what's wrong here?

> I take back the wrong statement, I misread the patch just now.

good, we are making some progress...

> But if you don't think the patch is ugly then I don't think we're looking at
> the same thing. For example

>> +static int __devinit mthca_check_profile_value(int* pval, int pval_default){

> and so on...

I see. Being less familiar with __devinit and friends, will have to
educate myself a little to see why the current patch is ugly...
anyway, thanks for agreeing to fix it yourself.

Or.