[openib-general] [PATCH] osm: state manager return wrong signal

Eitan Zahavi eitan at mellanox.co.il
Mon Dec 18 13:55:58 PST 2006


Hi Hal,

The discrepancies are due to my lack of git practice. I do not know why
these lines got back in.
The following line should not be there:

> >               */
> >              signal = OSM_SIGNAL_NONE;
> 
> This was eliminated as part of your original osm_state_mgr.c patch.
> Should it be there ? If so, this isn't indicated as a +.
> 
> -- Hal
> 
> >              break;
> > -
> >           case OSM_SIGNAL_NO_PENDING_TRANSACTIONS:
> >              /*
> >               * A change was detected on the subnet.
> > @@ -2219,7 +2219,10 @@ osm_state_mgr_process(
> >              signal = osm_pkey_mgr_process( p_mgr->p_subn->p_osm );
> >
> >              /* the returned signal is always DONE */
> > -            signal = osm_qos_setup(p_mgr->p_subn->p_osm);
> > +            tmp_signal = osm_qos_setup(p_mgr->p_subn->p_osm);
> > +
> > +            if (tmp_signal == OSM_SIGNAL_DONE_PENDING)
> > +               signal = OSM_SIGNAL_DONE_PENDING;
> >
> >              /* try to restore SA DB (this should be before lid_mgr
> >                 because we may want to disable clients
reregistration




More information about the general mailing list