[openib-general] [PATCH] osm: fix simulator vendor not initializing complete mad address

Eitan Zahavi eitan at mellanox.co.il
Thu Dec 21 11:14:11 PST 2006


Hi Hal,

This fix resolves the issue I have seen on osmtest InformInfo flow.
I am still not sure it is correct to compare sender address in the SA 
InformInfo receiver
by simply comparing the entire osm_mad_addr structure. But anyway, at 
least the simulator now behaves like the rest of the stacks.

The fix makes sure we init the complete mad address structure before 
copying the relevant data.

Signed-off-by: Eitan Zahavi <eitan at mellanox.co.il>
---
 osm/libvendor/osm_vendor_mlx_sim.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/osm/libvendor/osm_vendor_mlx_sim.c 
b/osm/libvendor/osm_vendor_mlx_sim.c
index 4692df0..d3e6eeb 100644
--- a/osm/libvendor/osm_vendor_mlx_sim.c
+++ b/osm/libvendor/osm_vendor_mlx_sim.c
@@ -381,6 +381,7 @@ __osmv_ibms_mad_addr_to_osm_addr(
   IN uint8_t is_smi,
   OUT osm_mad_addr_t *p_osm_addr)
 {
+  memset(p_osm_addr, 0, sizeof(osm_mad_addr_t));
   p_osm_addr->dest_lid = cl_hton16(p_ibms_addr->slid);
   p_osm_addr->static_rate = 0;
   p_osm_addr->path_bits = 0;
-- 
1.4.4.1.GIT





More information about the general mailing list