[openib-general] libsdp.conf placement

[Michael S. Tsirkin]

> >>>>> I noticed autotools have sysconfdir variable.
> >>>>> So it seems to me this would be the best, standard, place to keep the
> >>>>> libsdp.conf file.
> >>>>>
> >>>>> Eitan?
> >>>>>
> >>>>>   
> >>>>>       
> >>>>>           
> >>>> Unfortunately autotools are not doing the right thing.
> >>>> Quoting from libsdp Makefile.am:
> >>>> AM_CFLAGS = -Wall -DSYSCONFDIR=\"$(sysconfdir)\"
> >>>>
> >>>> And then internally in the port.c code:
> >>>> #define LIBSDP_DEFAULT_CONFIG_FILE  SYSCONFDIR "/libsdp.conf"
> >>>>
> >>>> Somehow when you run ./configure you get $prefix/etc as the $sysconfdir
> >>>>     
> >>>>         
> >>> So, that's what all other libraries that use autotools will get
> >>> (e.g. libibverbs) and that's the best default place then.
> >>>
> >>> If we want to, OFED can override sysconfdir with a configure switch, can it not?
> >>>   
> >>>       
> >> Yes it can but some people might want to upgrade just libsdp. For those 
> >> I would preferably use a more reasonable sysconfig then $prefix/etc
> >>     
> >
> > I think these people can use a configure switch, too (updating
> > just libsdp without OFED needs playing with configure switches anyway,
> > because of all the 64/32 bit situation).
> >
> > My point is, let's not mess with the defaults unless strictly necessary -
> > otherwise libibverbs config is in one place, and libsdp is in another,
> > and its a mess.
> >
> >   

So we are in agreement libsdp will put its config file in $sysconfigdir,
and let packagers change where it points to?

> RPM making should use the --sysconfigdir option for configure.

OK, but if so it should do so for all libraries, not just libsdp. Right?

> Still the default is broken.

Looks like a matter of taste. What is important is to keep it consistent across
all libraries in OFED.

> I will probably find a way to fix that .. 
> one day.

But for now, it defaults to $prefix/etc and if we want, OFED will override that
as appropriate?

-- 
MST