[openib-general] [PATCH 1/3 v2] osm: Changes for windows compatability

Michael S. Tsirkin mst at mellanox.co.il
Wed Dec 27 10:10:48 PST 2006


> > Hi Hal.
> > 
> > Fixing windows compilation problems
> > [V2 - Previous patch had an error]
> > 
> > Signed-off-by: Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>
> 
> Thanks. Applied.

The log is not really informative - shouldn't it say what does this fix?
In this case, it is forcing a specific calling convention on code -
its a bit more that just "fixing compilation" as it claims.

I'm worried that windows-related patches don't seem to be properly peer-reviewed.
Wouldn't looking things up on msdn before applying windows-related stuff be
a good idea?

-- 
MST




More information about the general mailing list