[openib-general] Re: [PATCH] enable the fmr pool user to set the page size

Roland Dreier rdreier at cisco.com
Thu Feb 2 10:45:27 PST 2006


I applied this and queued it for 2.6.17, but I'm a little worried
about how much testing you have done with this.  It looks safe enough
but your patch didn't even compile, due to the extra ";" in

 > 		struct ib_fmr_attr attr = {
 >			.max_pages = params->max_pages_per_fmr,
 >			.max_maps  = IB_FMR_MAX_REMAPS,
 > -			.page_size = PAGE_SHIFT
 > +			.page_shift = params->page_shift;

and also a bunch of missed page_size -> page_shift conversions in
mthca_mr.c.

 - R.



More information about the general mailing list