[openib-general] Re: ipoib_mcast_send.patch

[Roland Dreier]

    Michael> Maybe the description is not clear enough.  There are two
    Michael> issues here with two separate fixes.

OK, got it now.

    Michael> 1. IPOIB_MCAST_STARTED - solves the first issue
    Michael> 2. Checking priv->broadcast in ipoib_mcast_send here: +
    Michael> if (!test_bit(IPOIB_MCAST_STARTED, &priv->flags) ||
    Michael> !priv->broadcast) { - solves the second issue

Makes sense.  Related to this, the way priv->broadcast is initialized
in ipoib_mcast_join_task() looks somewhat unsafe, since there's no
lock and conceivable a send-only join could complete before
priv->broadcast is fully set up.  What do you think?

    Michael> They just got rolled into one patch because they touch
    Michael> the same code lines.

    Michael> Do you want me to split them up?

No, I can handle it.  Thanks...

 - R.