[openib-general] Re: [PATCH] mthca - command interface

Michael S. Tsirkin mst at mellanox.co.il
Mon Feb 13 04:56:26 PST 2006


Quoting Eli Cohen <eli at mellanox.co.il>:
> This patch implements posting commands by issuing posted writes in a
> manner similar to doorbells. The benefit of this method is that it does
> not require polling the go bit before posting the command and thus can
> lower CPU utilization.
> 
> Signed-off-by: Eli Cohen <eli at mellanox.co.il>
> Signed-off-by: Michael S. Tsirkin <mst at mellanox.co.il>

No real problem here, but I dont think you need to add Signed-off-by: Michael S.
Tsirkin to patches you post to openib by yourself, just because I went over the
patch coding-style-wise.

Documentation/SubmittingPatches says:
"The sign-off is a simple line at the end of the explanation for the
patch, which certifies that you wrote it or otherwise have the right to
pass it on as a open-source patch."

-- 
Michael S. Tsirkin
Staff Engineer, Mellanox Technologies



More information about the general mailing list