[openib-general] [PATCH 1/4] [RFC] Add ib_modify_qp_is_ok to core

Roland Dreier rdreier at cisco.com
Mon Feb 13 07:26:17 PST 2006


    Dotan> What about common code that check the validity of the
    Dotan> attributes of the modify QP (for example pkey_idx)?

Consolidating common code is always good.  I will always like a patch
that moves code that appears in multiple places into a core function.
Usually it's better to put it in a library function so that low-level
drivers can override it if necessary.

 - R.



More information about the general mailing list