[openib-general] Re: [PATCH] add asm-generic/mman.h

Badari Pulavarty pbadari at us.ibm.com
Wed Feb 15 09:40:50 PST 2006


On Wed, 2006-02-15 at 09:28 -0800, Linus Torvalds wrote:
> 
> On Wed, 15 Feb 2006, Michael S. Tsirkin wrote:
> >
> > Other numbers look right, dont they?
> 
> Suggestion: for each macro name, do
> 
> 	grep "macroname" patch
> 
> and if you see anything that looks even half-way suspicious, check it.
> 
> Here's a pipeline from hell which shows that you broke at least 
> MADV_REMOVE (which has values 5-9 depending on architecture).

Yes. I did that earlier and checked everything.

MADV_REMOVE is a known change. Since it added very recently,
I guess is okay to fix it for real. But if we are going to
change it, I am hoping to see it very soon in mainline. 
(Before distros fork-off).

Thanks,
Badari




More information about the general mailing list