[openib-general] Re: PATCH] mthca - command interface - revised

Roland Dreier rdreier at cisco.com
Wed Feb 15 13:18:43 PST 2006


    Eli> Roland, this patch is modified according to your comments. It
    Eli> also adds a kernel configuration option which selects whether
    Eli> to use posting commands through doorbells. The option is off
    Eli> by default.

Why make a config option?  Is there any reason why someone would want
to disable this feature, assuming the firmware supports it?

If there is some reason to turn this off, then a module parameter
would make more sense to me -- otherwise a kernel config option means
that a recompile is necessary to change the setting, and distros won't
ship drivers with the option turned on.

 - R.



More information about the general mailing list