[openib-general] Re: [PATCH 02/22] Firmware interface code for IB device.

[Christoph Hellwig]

On Fri, Feb 17, 2006 at 06:04:56PM -0800, Roland Dreier wrote:
>     Greg> Roland, your comments are fine, but what about the original
>     Greg> author's descriptions of what each patch are?
> 
> This is actually me breaking up a giant driver into pieces small
> enough to post to lkml without hitting the 100 KB limit.
> 
> This is just an RFC -- I assume the driver is going to get merged in
> the end as one big git changeset with a changelog like "add driver for
> IBM eHCA InfiniBand adapters".
> 
>     Greg> Come on, IBM allows developers to post code to lkml, just
>     Greg> look at the archives for proof.  For them to use a proxy
>     Greg> like this is very strange, and also, there is no
>     Greg> Signed-off-by: record from the original authors, which is
>     Greg> not ok.
> 
> Well, the eHCA guys tell me that they can't post patches to lkml.

Then they lie.  And not posting to lkml is a good reason not to merge
an otherwise perfect driver.  (which this one is far from)