[openib-general] [PATCH] iser: fixed sparse warnings

Or Gerlitz ogerlitz at voltaire.com
Sun Feb 19 01:08:52 PST 2006


------------------------------------------------------------------------
r5442 | ogerlitz | 2006-02-19 11:05:17 +0200 (Sun, 19 Feb 2006) | 4 lines

fixed sparse warnings

Signed-off-by: Or Gerlitz <ogerlitz at voltaire.com>


Index: iser_socket.c
===================================================================
--- iser_socket.c	(revision 5427)
+++ iser_socket.c	(revision 5442)
@@ -45,7 +45,7 @@ static int iser_sock_create(struct socke
 static int iser_sock_release(struct socket *);
 static int iser_sock_connect(struct socket *, struct sockaddr *, int, int);
 static int iser_sock_shutdown(struct socket *,int);
-static int iser_sock_getsockopt(struct socket *,int,int,char *,int *);
+static int iser_sock_getsockopt(struct socket *,int,int,char __user *,int __user *);
 static unsigned int iser_sock_poll(struct file *,struct socket *,
 				   struct poll_table_struct *);
 
@@ -55,40 +55,40 @@ struct iser_sock {
 };
 
 static struct net_proto_family iser_proto_family = {
-	family: PF_ISER,
-	create: iser_sock_create,
-	authentication: 0,
-	encryption: 0,
-	encrypt_net: 0,
+	.family		= PF_ISER,
+	.create		= iser_sock_create,
+	.authentication = 0,
+	.encryption	= 0,
+	.encrypt_net	= 0
 };
 
 static struct proto_ops iser_proto_ops = {
-	family:		AF_ISER,
-	owner:		THIS_MODULE,
+	.family		= AF_ISER,
+	.owner		= THIS_MODULE,
 
-	connect:	iser_sock_connect,
-	release:	iser_sock_release,
-	shutdown:	iser_sock_shutdown,
-
-	bind:		sock_no_bind,
-	poll:		iser_sock_poll,
-	socketpair:	sock_no_socketpair,
-	accept:		sock_no_accept,
-	getname:	sock_no_getname,
-	ioctl:		sock_no_ioctl,
-	listen:		sock_no_listen,
-	setsockopt:	sock_setsockopt,
-	getsockopt:	iser_sock_getsockopt,
-	sendmsg:	sock_no_sendmsg,
-	recvmsg:	sock_no_recvmsg,
-	mmap:		sock_no_mmap,
-	sendpage:	sock_no_sendpage,
+	.connect	= iser_sock_connect,
+	.release	= iser_sock_release,
+	.shutdown	= iser_sock_shutdown,
+
+	.bind		= sock_no_bind,
+	.poll		= iser_sock_poll,
+	.socketpair	= sock_no_socketpair,
+	.accept		= sock_no_accept,
+	.getname	= sock_no_getname,
+	.ioctl		= sock_no_ioctl,
+	.listen		= sock_no_listen,
+	.setsockopt	= sock_setsockopt,
+	.getsockopt	= iser_sock_getsockopt,
+	.sendmsg	= sock_no_sendmsg,
+	.recvmsg	= sock_no_recvmsg,
+	.mmap		= sock_no_mmap,
+	.sendpage	= sock_no_sendpage
 };
 
 static struct proto iser_sock_proto = {
-	name: "ib_iser",
-	owner: THIS_MODULE,
-	obj_size: sizeof(struct iser_sock),
+	.name		= "ib_iser",
+	.owner		= THIS_MODULE,
+	.obj_size	= sizeof(struct iser_sock)
 };
 
 struct iser_conn *iser_conn_from_sock(struct socket *sock)
@@ -202,7 +202,7 @@ int iser_sock_shutdown(struct socket *so
 }
 
 static int iser_sock_getsockopt(struct socket *sock, int level, int optname,
-				char *optval, int *optlen)
+				char __user *optval, int __user *optlen)
 {
 	return 0;
 }



More information about the general mailing list