[openib-general] Re: [PATCH 03/22] pHype specific stuff

[Anton Blanchard]

Hi,

> +inline static u32 getLongBusyTimeSecs(int longBusyRetCode)
> +{
> +	switch (longBusyRetCode) {
> +	case H_LongBusyOrder1msec:
> +		return 1;
> +	case H_LongBusyOrder10msec:
> +		return 10;
> +	case H_LongBusyOrder100msec:
> +		return 100;
> +	case H_LongBusyOrder1sec:
> +		return 1000;
> +	case H_LongBusyOrder10sec:
> +		return 10000;
> +	case H_LongBusyOrder100sec:
> +		return 100000;
> +	default:
> +		return 1;
> +	}			/* eof switch */
> +}

Since this actually returns milliseconds it might be worth making it
obvious in the function name. Also no need to use studly caps for the
function name and variable. We will fix the studly caps H_LongBusy*
stuff another day :)

> +inline static long plpar_hcall_7arg_7ret(unsigned long opcode,
> +inline static long plpar_hcall_9arg_9ret(unsigned long opcode,

These belong in arch/powerpc/platforms/pseries/hvCall.S

Anton