[openib-general] [PATCH 3/6] [RFC] iser initiator

[Or Gerlitz]

Christoph Hellwig wrote:

>> +static int iser_dma_map_task_data(struct iscsi_iser_cmd_task *p_iser_task,
>> +				  struct iser_data_buf       *p_data,
...
>> +	if (p_data->type == ISER_BUF_TYPE_SINGLE) {
>> +		p_iser_task->data_len[iser_dir] = p_data->size;
>> +		dma_addr = dma_map_single(dma_device,p_data->p_buf, p_data->size,

> I'd say kill the non-SG case.  We're in the progress of removing non-SG
> commands in the scsi midlayer, and I'm pretty sure they won't exist
> anymore before the iser code merged.

Indeed i see that driver/scsi/iscsi_tcp.c of 2.6.16-rc1 (and on) does 
not support non-SG SCSI commands. Can you confirm that as of 2.6.16 a 
SCSI LLD does not need to support the non-SG case?

OK - the code for upstream will assume only SG commands.

Now, regardless of when iSER is to be merged, it is used with 2.6.15 and 
older kernels that do issue non-SG commands. I wonder what would be the 
simplest patch to support it, does it make sense to use virt_to_page on 
  sc->request_buffer to compose one entry SG on the fly and use it down 
the code?

Or.