[openib-general] [PATCH 3/6] [RFC] iser initiator

[Mike Christie]

Mike Christie wrote:
> Or Gerlitz wrote:
> 
>>Christoph Hellwig wrote:
>>
>>
>>
>>>>+static int iser_dma_map_task_data(struct iscsi_iser_cmd_task *p_iser_task,
>>>>+				  struct iser_data_buf       *p_data,
>>
>>...
>>
>>
>>>>+	if (p_data->type == ISER_BUF_TYPE_SINGLE) {
>>>>+		p_iser_task->data_len[iser_dir] = p_data->size;
>>>>+		dma_addr = dma_map_single(dma_device,p_data->p_buf, p_data->size,
>>
>>
>>>I'd say kill the non-SG case.  We're in the progress of removing non-SG
>>>commands in the scsi midlayer, and I'm pretty sure they won't exist
>>>anymore before the iser code merged.
>>
>>
>>Indeed i see that driver/scsi/iscsi_tcp.c of 2.6.16-rc1 (and on) does 
>>not support non-SG SCSI commands.
> 
> 
> We should still support them in 2.6.16. We have not cleaned out that 
> code yet. We are doing the header fixup at the same time. That patch to 
> use change when we use sendmsg/sendpage should not have broken the 
> non-sg case. Did it?
> 
>   Can you confirm that as of 2.6.16 a
> 
>>SCSI LLD does not need to support the non-SG case?
> 
> 
> For new software iscsi I do not think there is no need to support non-sg 

replace "no" with "a" :)