This looks OK, I guess, but... Mst> ipoib_mcast_send tests mcast->ah twice. If this value Mst> is changed between these two points, we leak an skb. who else might change the value here? Answering this would help justify the patch and save me from having to write up a changelog entry. - R.