[openib-general] Re: [PATCH] ib_mad: prevent duplicateoutstanding MADtransactions with same TID

[Michael S. Tsirkin]

Quoting Jack Morgenstein <jackm at mellanox.co.il>:
> Prevent issuing multiple MAD transactions with the same TID.
> Could happen if duplicate requests are posted.
> 
> Signed-off-by: Jack Morgenstein <jackm at mellanox.co.il>
> Signed-off-by: Michael S. Tsirkin <mst at mellanox.co.il>

This is actually affecting duplicate responses as well, isn't it?
As far as I remember, duplicate RMPP responses corrupting each other is
something that we saw in the lab with opensm, so it would be nice to have that
fixed for 2.6.17 (or even for 2.6.16 if possible?).

I think the problem with this specific patch was that ib_find_send_mad
ignores the remote address (and method?) when doing lookup,
so its wrong to use it to check that the transaction is in progress.
This shouldnt be hard to fix, though, should it?

We should just check the packet method, and compare source/destination GIDs
as appropriate. The remote GID can be got from ib_query_ah. Right?

-- 
Michael S. Tsirkin
Staff Engineer, Mellanox Technologies