[openib-general] [PATCH] mthca: cosmetic change in mthca_qp

Michael S. Tsirkin mst at mellanox.co.il
Mon Jan 9 06:54:33 PST 2006


Roland, how does the following look?

---

Cosmetic change in mthca_qp.

Signed-off-by: Michael S. Tsirkin <mst at mellanox.co.il>

Index: openib/drivers/infiniband/hw/mthca/mthca_qp.c
===================================================================
--- openib/drivers/infiniband/hw/mthca/mthca_qp.c	(revision 4505)
+++ openib/drivers/infiniband/hw/mthca/mthca_qp.c	(working copy)
@@ -754,13 +754,10 @@ int mthca_modify_qp(struct ib_qp *ibqp, 
 	}
 
 	if (attr_mask & IB_QP_MAX_QP_RD_ATOMIC) {
-		if (attr->max_rd_atomic) {
-			qp_context->params1 |=
-				cpu_to_be32(MTHCA_QP_BIT_SRE |
-					    MTHCA_QP_BIT_SAE);
-			qp_context->params1 |=
-				cpu_to_be32(fls(attr->max_rd_atomic - 1) << 21);
-		}
+		if (attr->max_rd_atomic)
+			qp_context->params1 |= cpu_to_be32(MTHCA_QP_BIT_SRE |
+							   MTHCA_QP_BIT_SAE |
+							   (fls(attr->max_rd_atomic - 1) << 21));
 		qp_param->opt_param_mask |= cpu_to_be32(MTHCA_QP_OPTPAR_SRA_MAX);
 	}
 

-- 
MST



More information about the general mailing list