[openib-general] Re: Re[PATCH] Opensm - fix for osm_sa_portinfo_record.c

[Hal Rosenstock]

Hi Yael,

On Mon, 2006-01-09 at 07:29, Yael Kalka wrote:
> Hi Hal,
> 
> During some tests we've notices that not all compmask fields are
> properly checked and compared in the portInfo record query.
> Attached is a patch with the missing checks, and addition of some
> set/get relevant functions added to the ib_types.h as well.

Just a couple of minor (nit) comments below.

-- Hal

> Thanks,
> Yael
> 
> Signed-off-by:  Yael Kalka <yael at mellanox.co.il>
> 
> Index: include/iba/ib_types.h
> ===================================================================
> --- include/iba/ib_types.h	(revision 4809)
> +++ include/iba/ib_types.h	(working copy)
> @@ -3960,6 +3960,33 @@ ib_port_info_get_vl_cap(
>  *
>  * SEE ALSO
>  *********/
> +/****f* IBA Base: Types/ib_port_info_get_init_type
> +* NAME
> +*	ib_port_info_get_init_type
> +*
> +* DESCRIPTION
> +*	Gets the VL Capability of a port.
                   ^^^^^^^^^^^^^
                   init type
> +*
> +* SYNOPSIS
> +*/
> +static inline uint8_t
> +ib_port_info_get_init_type(
> +	IN const ib_port_info_t* const p_pi)
> +{
> +	return(p_pi->vl_cap & 0x0F);

Should this be:
	return (uint8_t) (p_pi->vl_cap & 0x0F);

> +}
> +/*
> +* PARAMETERS
> +*	p_pi
> +*		[in] Pointer to a PortInfo attribute.
> +*
> +* RETURN VALUES
> +*	InitType field
> +*
> +* NOTES
> +*
> +* SEE ALSO
> +*********/

[snip...]

-- Hal