[openib-general] [git patch review 5/7] IB: Add node_guid to struct ib_device

Or Gerlitz ogerlitz at voltaire.com
Wed Jan 11 05:53:59 PST 2006


Roland,

It does not seems that you have applied the patch to ib_verbs.h.
Was it forgotten?

Or.

Roland Dreier wrote:
> Add a node_guid field to struct ib_device.  It is the responsibility
> of the low-level driver to initialize this field before registering a
> device with the midlayer.  Convert everyone to looking at this field
> instead of calling ib_query_device() when all they want is the node
> GUID, and remove the node_guid field from struct ib_device_attr.
> 
> Signed-off-by: Sean Hefty <sean.hefty at intel.com>
> Signed-off-by: Roland Dreier <rolandd at cisco.com>
> 
> ---
> 
>  drivers/infiniband/core/cm.c                 |   29 +++----------------
>  drivers/infiniband/core/sysfs.c              |   22 +++-----------
>  drivers/infiniband/core/uverbs_cmd.c         |    2 +
>  drivers/infiniband/hw/mthca/mthca_provider.c |   40 +++++++++++++++++++++++++-
>  drivers/infiniband/ulp/srp/ib_srp.c          |   23 +++------------
>  include/rdma/ib_verbs.h                      |    2 +
>  6 files changed, 54 insertions(+), 64 deletions(-)
> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
> index a7f4c35..22fc886 100644
> --- a/include/rdma/ib_verbs.h
> +++ b/include/rdma/ib_verbs.h
> @@ -88,7 +88,6 @@ enum ib_atomic_cap {
>  
>  struct ib_device_attr {
>  	u64			fw_ver;
> -	__be64			node_guid;
>  	__be64			sys_image_guid;
>  	u64			max_mr_size;
>  	u64			page_size_cap;
> @@ -951,6 +950,7 @@ struct ib_device {
>  	u64			     uverbs_cmd_mask;
>  	int			     uverbs_abi_ver;
>  
> +	__be64			     node_guid;
>  	u8                           node_type;
>  	u8                           phys_port_cnt;
>  };





More information about the general mailing list