[openib-general] [PATCH] Problem with directed route SMPs with beginning or ending LID routed parts

Hal Rosenstock halr at voltaire.com
Fri Jan 13 04:05:50 PST 2006


Hi Ralph,

On Thu, 2006-01-12 at 21:44, Ralph Campbell wrote:
> I have only done basic testing (i.e., the link comes up and IPoIB still works)
> but I think this fixes the problem.

This looks good to me with the one possible improvement below. Has SM
been tested too with this ?

[snip...] 

> Index: hw/mthca/mthca_mad.c
> ===================================================================
> --- hw/mthca/mthca_mad.c	(revision 4978)
> +++ hw/mthca/mthca_mad.c	(working copy)
> @@ -117,7 +117,8 @@
>  	unsigned long flags;
>  
>  	if (agent) {
> -		send_buf = ib_create_send_mad(agent, qpn, 0, 0, IB_MGMT_MAD_HDR,
> +		send_buf = ib_create_send_mad(agent, qpn, 0, 0, 0,
> +					      IB_MGMT_MAD_HDR,
>  					      IB_MGMT_MAD_DATA, GFP_ATOMIC);
>  		/*
>  		 * We rely here on the fact that MLX QPs don't use the

Traps currently are LID routed so this is works. But directed route
traps are supported so similar code could be added here.

-- Hal




More information about the general mailing list