[openib-general] Re: ipoib_mcast_send.patch

Michael S. Tsirkin mst at mellanox.co.il
Tue Jan 17 12:31:36 PST 2006


Quoting Roland Dreier <rdreier at cisco.com>:
> It seems that this code at the end of ipoib_mcast_join_task() might
> screw things up:
> 
> 	ipoib_dbg_mcast(priv, "successfully joined all multicast groups\n");
> 
> 	clear_bit(IPOIB_MCAST_RUN, &priv->flags);

Right. That probably was the reason I invented MCAST_STARTED.

> Probably the semantics of IPOIB_MCAST_RUN need to change slightly.
> I'm not sure this necessarily can be made to work -- maybe we just
> need more than one bit of status information to handle everything.

Kind of like what original patch in svn does?

-- 
MST



More information about the general mailing list