[openib-general] Re: [PATCH] CMA and iWARP

[Steve Wise]

On Thu, 2006-01-19 at 10:20 -0800, Sean Hefty wrote:
> Tom Tucker wrote:
> > Enclosed is a combined include file and core patch for iWARP support in CMA. This 
> > patch includes changes per your last review. 
> 
> It was brought up that there's still not an iWarp driver in the OpenIB trunk. 
> Is one ready to be merged?  Thinking about this more, I'm not sure that we want 
> to merge these changes into the trunk without one.  (I can see arguments both 
> ways.)  Comments?

The Ammasso rnic code could be merged in at this point.  But the company
Ammasso is no more, so I question whether we want it in the main trunk?


> Looking at the patch, it seems that the biggest issue that you would have with 
> merging changes is how the cm_id is stored.  I can at least fold that change 
> into the CMA to help with maintenance if an iWarp driver isn't ready yet.
> 

Getting the core changes in now will help avoid having to keep merging
trunk code back into the iwarp branch.  It will also expose the iwarp
changes to a larger audience for review and improvement.  

My 2 cents.


Steve.