[openib-general] Re: [PATCH] CMA and iWARP

[Tom Tucker]

On Thu, 2006-01-19 at 10:20 -0800, Sean Hefty wrote:
> Tom Tucker wrote:
> > Enclosed is a combined include file and core patch for iWARP support in CMA. This 
> > patch includes changes per your last review. 
> 
> It was brought up that there's still not an iWarp driver in the OpenIB trunk. 
> Is one ready to be merged?  Thinking about this more, I'm not sure that we want 
> to merge these changes into the trunk without one.  (I can see arguments both 
> ways.)  Comments?

I have a few comments:

1. We can place the AMSO1100 driver into the trunk if we want, but I
can't imagine that this will ever hit the kernel because Ammasso (RIP)
is dead.

2. There will almost certainly be multiple iWARP drivers by end of
1Q'06. The developers of these drivers would be better served if they
were pulling from the trunk instead of a branch that gets old by the
hour.

3. Getting the core support in early will give us time to tweak, tune,
and test. I think this is a very good thing.

> 
> Looking at the patch, it seems that the biggest issue that you would have with 
> merging changes is how the cm_id is stored.  I can at least fold that change 
> into the CMA to help with maintenance if an iWarp driver isn't ready yet.
> 
> - Sean

I think we need the ib_verbs.h changes as well for item 2 above.