[openib-general] [PATCH] [MAD] set RMPP version even if RMPP is not active

Hal Rosenstock halr at voltaire.com
Tue Jan 24 15:19:38 PST 2006


On Tue, 2006-01-24 at 17:05, Sean Hefty wrote:
> Sean Hefty wrote:
> > The RMPP code actually checks the active flag before checking the version, which
> > is wrong, but why this has gone undetected.
> 
> On second thought, and checking the spec in more detail...
> 
> o13-21.1.3: States that if Active=0, all other fields shall be reserved.
> 
> and
> 
> o13-21.1.4: Adds that version shall have a value of 1 in all MADs where Active=1.
> 
> Given this, I think that the current code _is_ correct.  It's the spec that's
> seems broken...

Guess the active bit needs to always stay the same regardless of the
RMPP version.

-- Hal




More information about the general mailing list