[openib-general] Re: [PATCH] extend ib_device node_type to include iWarp

[Sean Hefty]

Roland Dreier wrote:
> That's still silly.  I wasn't very clear in my original email.  But my
> point was that if a function does
> 
> 	if ((device->node_type & IB_NODE_IB) != IB_NODE_IB)
> 		return;
> 
> then we should just write tests like
> 
> 	if (device->node_type == IB_NODE_SWITCH) {

I understand.  This sort of test works since IB_NODE_IB = 0, but wouldn't work 
for IB_NODE_IWARP, where node_type = IB_NODE_IWARP | IB_NODE_CA.

- Sean