[openib-general] [PATCH] mthca: initialize send and receive queue locks separately

Michael S. Tsirkin mst at mellanox.co.il
Tue Jul 4 20:07:45 PDT 2006


Quoting r. Roland Dreier <rdreier at cisco.com>:
> I think that is actually a very minor bug you've found.  If someone
> were posting a work request at the same time as they transitioned a QP
> to reset (which is a legitimate if not sensible thing to do), then the
> spinlock could get reinitialized while it was held.  Which would be
> bad.

I think you can't post work requests to a QP in reset state, since IB spec
forbids this. If you do, it seems bad things will happen anyway, for example
head/tail pointers may get out of sync as mthca_wq_init clears these.

-- 
MST




More information about the general mailing list