[openib-general] [PATCH] IB/mthca: comment fix
Michael S. Tsirkin
mst at mellanox.co.il
Mon Jul 10 04:14:12 PDT 2006
Hi Andrew,
Here's a cosmetic patch for IB/mthca. Pls drop it into -mm and on.
---
comment in mthca_qp.c makes it seem lockdep is the only reason WQ locks should
be initialized separately, but as Zach Brown and Roland pointed out, there are
other reasons, e.g. that mthca_wq_init is called from modify qp as well.
Signed-off-by: Michael S. Tsirkin <mst at mellanox.co.il>
diff --git a/drivers/infiniband/hw/mthca/mthca_qp.c b/drivers/infiniband/hw/mthca/mthca_qp.c
index 490fc78..2f3917e 100644
--- a/drivers/infiniband/hw/mthca/mthca_qp.c
+++ b/drivers/infiniband/hw/mthca/mthca_qp.c
@@ -1114,7 +1114,7 @@ static int mthca_alloc_qp_common(struct
qp->sq_policy = send_policy;
mthca_wq_init(&qp->sq);
mthca_wq_init(&qp->rq);
- /* these are initialized separately so lockdep can tell them apart */
+
spin_lock_init(&qp->sq.lock);
spin_lock_init(&qp->rq.lock);
--
MST
More information about the general
mailing list