[openib-general] [RFC] [PATCH 3/7] ibrdmaverbs hdr files

[James Lentini]

What are the differences between this and the libibverbs? Is it only 
that the ibv_ prefix was changed to rdma_? 

Long term, I don't think it makes sense having two libraries with 
the exact same functionality, but different function names. 
Replacing ibv_ with rdma_ would be ideal, but disruptive to current 
users. Could you provide a backwards compatibility header (one that 
mapped each ibv_ function to its equivalent rdma_ function)?

One additional comment below:

On Mon, 10 Jul 2006, Krishna Kumar wrote:

> diff -ruNp ORG/librdmaverbs/include/rdma/arch.h NEW/librdmaverbs/include/rdma/arch.h
> --- ORG/librdmaverbs/include/rdma/arch.h	1969-12-31 16:00:00.000000000 -0800
> +++ NEW/librdmaverbs/include/rdma/arch.h	2006-07-10 18:07:46.000000000 -0700
> @@ -0,0 +1,95 @@
> +/*
> + * Copyright (c) 2005 Topspin Communications.  All rights reserved.
> + *
> + * This software is available to you under a choice of one of two
> + * licenses.  You may choose to be licensed under the terms of the GNU
> + * General Public License (GPL) Version 2, available from the file
> + * COPYING in the main directory of this source tree, or the
> + * OpenIB.org BSD license below:
> + *
> + *     Redistribution and use in source and binary forms, with or
> + *     without modification, are permitted provided that the following
> + *     conditions are met:
> + *
> + *      - Redistributions of source code must retain the above
> + *        copyright notice, this list of conditions and the following
> + *        disclaimer.
> + *
> + *      - Redistributions in binary form must reproduce the above
> + *        copyright notice, this list of conditions and the following
> + *        disclaimer in the documentation and/or other materials
> + *        provided with the distribution.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
> + * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
> + * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
> + * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
> + * SOFTWARE.
> + *
> + * $Id: arch.h 6987 2006-05-08 15:18:51Z tom $
> + */
> +
> +#ifndef INFINIBAND_ARCH_H
> +#define INFINIBAND_ARCH_H

I wouldn't prefix all of you include guards with INFINIBAND_. Not only 
is it confusing, but it collides with the libibverbs headers. I'd 
suggest using RDMA_ instead.