[openib-general] ipoib lockdep warning
Ingo Molnar
mingo at elte.hu
Wed Jul 12 02:38:20 PDT 2006
* Roland Dreier <rdreier at cisco.com> wrote:
> Hmm, good point.
>
> It sort of seems to me like the idr interfaces are broken by design.
[...]
> So, ugh... maybe the best thing to do is change lib/idr.c to use
> spin_lock_irqsave() internally?
i agree that the IDR subsystem should be irq-safe if GFP_ATOMIC is
passed in. So the _irqsave()/_irqrestore() fix should be done.
But i also think that you should avoid using GFP_ATOMIC for any sort of
reliable IO path and push as much work into process context as possible.
Is it acceptable for your infiniband IO model to fail with -ENOMEM if
GFP_ATOMIC happens to fail, and is the IO retried transparently?
Ingo
More information about the general
mailing list