[openib-general] [PATCH 2/2] ib_cm: fix REJ due to invalid GID

[Michael S. Tsirkin]

Quoting r. Sean Hefty <sean.hefty at intel.com>:
> Subject: RE: [PATCH 2/2] ib_cm: fix REJ due to invalid GID
> 
> >By the way, AFAIK  by design cache might be out of sync with actual hardware.
> >Roland, could you confirm this pls?
> >
> >So if we look things up in cache and they are not there there must be
> >a retry strategy which is missing if we reject the connection.
> >A quick solution would be to force cache update before reject,
> >or query device directly.
> 
> If we're trying to look up a specific value, and it's not found in the cache, my
> preference would be for the cache code to update itself and retry the check
> before returning.

That's impossible without API cange since cache queries could be used
from interrupt context as well, while cache update might sleep.

My preference would be to add a new set of APIs that wrap existing
cache and do what you propose - this way they can be added where
required and not all over the code.


-- 
MST