[openib-general] 2 patches in mst-for-2.6.18

[Sean Hefty]

Roland Dreier wrote:
>  > [PATCH] IB/mad: validate MADs for spec compliance C13-18.1.1
> 
> Seems fine but I wonder why the ib_response_mad function moved into a
> public header.

This functionality was implemented / called from several places.  Private 
implementations have been replaced with a single public call.

> Also, how does this patch do this:
> 
>  > Also verify that RMPP MADs are data only, to avoid a userspace
>  > app causing a kernel crash by sending non-data MADs.
> 
> what is the crash?  And how does adding a check for the BM class fix this?

I think this is just an invalid comment.  The user MAD code in the kernel 
already prevented a userspace app from sending non-data MADs.  I removed this 
comment when performing the actual commit to svn (revision 8498).

Michael, did you pull in the patch from svn, or that posted to the list?  There 
could have been minor differences between them.

- Sean