[openib-general] [PATCH 3/4] IB CM: register and handle COMM_EST events on a QP

[James Lentini]

Sean,

Thanks for working on this. One minor suggestion below:

On Fri, 21 Jul 2006, Sean Hefty wrote:

> @@ -3308,6 +3430,7 @@ static void cm_add_one(struct ib_device 
>  
>  	cm_dev->device = device;
>  	cm_dev->ca_guid = device->node_guid;
> +	ib_register_cm_handler(device, cm_event_handler);

If ib_register_cm_handler() fails, how about logging an error message:

if (ib_register_cm_handler(device, cm_event_handler))
	printk(KERN_WARNING "IB CM unable to register CM handler\n);

>  
>  	set_bit(IB_MGMT_METHOD_SEND, reg_req.method_mask);
>  	for (i = 1; i <= device->phys_port_cnt; i++) {