[openib-general] [PATCH 1/6] libibverbs include files changes.

Sean Hefty mshefty at ichips.intel.com
Fri Jul 28 10:08:30 PDT 2006


Krishna Kumar wrote:
> +/**
> + * rdmav_create_qp - Create a queue pair.
> + */
> +struct rdma_qp *rdmav_create_qp(struct rdma_pd *pd,
> +			       struct rdma_qp_init_attr *qp_init_attr);
> +

> +/**
> + * rdmav_destroy_qp - Destroy a queue pair.
> + */
> +int rdmav_destroy_qp(struct rdma_qp *qp);

I realize why you did this, but adding the 'v' to these two calls makes them 
inconsistent with all the other calls in the API.  I don't know what the right 
approach is here, but it may be better to have the RDMA CM use different names.

- Sean




More information about the general mailing list