[openib-general] Re: [PATCHv2 1/2] resend: mthca support for max_map_per_fmr device attribute
Roland Dreier
rdreier at cisco.com
Mon Jun 5 09:01:14 PDT 2006
> Yes it makes sense, but you need the check should be
>
> if (!(dev->mthca_flags & MTHCA_FLAG_SINAI_OPT))
>
> instead of
>
> if (dev->mthca_flags & MTHCA_FLAG_SINAI_OPT)
Yep, you're right, I got it backwards.
> also, what about the other patch which changes fmr_pool.c to query the
> device, have you got(reviewed/accepted) it? i have modified it to
> allocate the device attr struct on the heap as you have asked.
It looks fine. I was just reviewing everything together.
- R.
More information about the general
mailing list