[openib-general] [PATCH 0/4] opensm: Loading unicast routes from the file

[Eitan Zahavi]

Hi Sasha,

General comments:
1. I hope the change in osm.fdbs is not going to break the parser in
ibdm:Fabric.cpp - was it really necessary change? or just nice to have ?
2. The modular routing is a great idea. From my first glance it seems
that it assumes calculation of min-hop-tables is common to all routing
engines. I think it should be a callback provided by the engine too.
Please note that the Min-Hop engine takes most of the routing time so in
the future if we could avoid that stage it would be even better. 

[EZ] We should start thinking about testing of this new feature too.

Further comment on the patches themselves.

> There are couple of unicast routing related patches for OpenSM.
> 
> Basically it implements routing module which provides possibility to
load
> switch forwarding tables from pre-created dump file. Currently unicast
> tables loading is only supported, multicast may be added in a future.
> 
> Short patch descriptions (more details may be found in emails with
> patches):
> 
> 1. Ucast dump file simplification.
> 2. Modular routing - preliminary implements generic model to plug new
> routing engine to OpenSM.
> 3. New simple unicast routing engine which allows to load LFTs from
> pre-created dump file.
> 4. Example of ucast dump generation script.
> 
> Please comment and test. Thanks.
> 
> Sasha