[openib-general] [PATCH] mad: prevent duplicate RMPP sessions on responder side

Michael S. Tsirkin mst at mellanox.co.il
Sun Jun 11 10:50:06 PDT 2006


Quoting r. Sean Hefty <mshefty at ichips.intel.com>:
> Subject: Re: [PATCH] mad: prevent duplicate RMPP sessions on responder side
> 
> Jack Morgenstein wrote:
> >Prevent opening multiple RMPP MAD transaction sessions at responder side
> >with the same TID, GID/LID, class.
> >
> >Could happen if RMPP requests are retried while response is in progress.
> 
> My preference for handling this is to detect and discard duplicate 
> requests, and verify that response MADs match a request when being sent.  
> See the mail thread starting at:
> 
> http://openib.org/pipermail/openib-general/2006-April/020703.html
> 
> This will also help us add in support for DS RMPP.
> 
> For kernel clients, I anticipate that this sort of change is fairly small. 
> Userspace support requires a bit more work, especially if we don't want to 
> change the ABI.

Sean, is anyone looking at this? If not, given that Jack's approach does not
touch ABI or API, might it make sense to merge Jack's patch after all and use
that as a starting point?  With current code in 2.6.17 large RMPPs often get
aborted because of the problem of the duplicates.  On the other hand, I'm not
aware of users for DS RMPP.

-- 
MST




More information about the general mailing list