[openib-general] [PATCH] mthca: memfree completion with error workaround

Roland Dreier rdreier at cisco.com
Mon Jun 12 13:47:40 PDT 2006


    Michael> It might not be too bad - there's a single additional
    Michael> test on fastpath, and I am guessing both wqe_index and
    Michael> rq.max should be in registers already.  Once wqe_index is
    Michael> out of rq.max range we are on slow path.

But it bloats the function and adds to i-cache footprint.  I'm sure it
benchmarks fine but it adds to general cache usage that pushes useful
code out of cache.

Unfortunately I don't see a clean way to move it out of line.

    Michael> We can make it a compile-time option, so that users can
    Michael> disable it once there's a firmware that does not need
    Michael> this code.

No distro is ever going to turn it off though.

 - R.




More information about the general mailing list