[openib-general] [PATCH] update libipathverbs library to the new initialization method
Ralph Campbell
ralphc at pathscale.com
Fri Jun 16 16:30:32 PDT 2006
On Fri, 2006-06-16 at 16:12 -0700, Roland Dreier wrote:
> > The current libipathverbs driver in the trunk doesn't
> > conform to the new module initialization convention for
> > libibverbs.so. This patch corrects that.
>
> Looks OK but you're now only compatible with unreleased development
> versions of libibverbs -- this won't work against the stable
> libibverbs 1.0 code shipped with Fedora and Debian for example.
>
> You might want to follow the approach libmthca uses to build against
> both libibverbs 1.0 and also pre-1.1 development code.
Its not hard to allow 1.1 libipathverbs to build against 1.0 libibverbs
for just this change but I suspect that the mmap stuff might not be
so easy or other 1.1 changes. I don't really think it makes sense
to support every combination of up and down rev compilation
and run time compatibility.
> > Also, with this patch, we can now try testing the performance
> > of Roland's changes to eliminate the single ib_uverbs_idr_mutex.
>
> Glad you're going to test, but why do you need this patch? Couldn't
> you just have put a new kernel onto a system with libibverbs 1.0 and
> the old libipathverbs?
>
> - R.
Sure. I was just in the middle of getting the trunk to run again
when you sent your request.
--
Ralph Campbell <ralphc at pathscale.com>
More information about the general
mailing list