[openib-general] trunk's udapl does not compile
Or Gerlitz
ogerlitz at voltaire.com
Mon Jun 19 07:30:16 PDT 2006
I've just noted an inconsistency with librdmacm of udapl calling
rdma_create_id without providing the PS param.
This is the trivial patch i was using to fix the compilation.
Or.
Index: dapl/openib_cma/dapl_ib_util.c
===================================================================
--- dapl/openib_cma/dapl_ib_util.c (revision 8106)
+++ dapl/openib_cma/dapl_ib_util.c (working copy)
@@ -235,7 +235,7 @@ DAT_RETURN dapls_ib_open_hca(IN IB_HCA_N
return DAT_INVALID_ADDRESS;
/* cm_id will bind local device/GID based on IP address */
- if (rdma_create_id(g_cm_events, &cm_id, (void*)hca_ptr))
+ if (rdma_create_id(g_cm_events, &cm_id, (void*)hca_ptr, RDMA_PS_TCP))
return DAT_INTERNAL_ERROR;
ret = rdma_bind_addr(cm_id,
Index: dapl/openib_cma/dapl_ib_cm.c
===================================================================
--- dapl/openib_cma/dapl_ib_cm.c (revision 8106)
+++ dapl/openib_cma/dapl_ib_cm.c (working copy)
@@ -694,7 +694,7 @@ dapls_ib_setup_conn_listener(IN DAPL_IA
dapl_os_lock_init(&conn->lock);
/* create CM_ID, bind to local device, create QP */
- if (rdma_create_id(g_cm_events, &conn->cm_id, (void*)conn)) {
+ if (rdma_create_id(g_cm_events, &conn->cm_id, (void*)conn, RDMA_PS_TCP)) {
dapl_os_free(conn, sizeof(*conn));
return(dapl_convert_errno(errno,"setup_listener"));
}
Index: dapl/openib_cma/dapl_ib_qp.c
===================================================================
--- dapl/openib_cma/dapl_ib_qp.c (revision 8106)
+++ dapl/openib_cma/dapl_ib_qp.c (working copy)
@@ -130,7 +130,7 @@ DAT_RETURN dapls_ib_qp_alloc(IN DAPL_IA
dapl_os_lock_init(&conn->lock);
/* create CM_ID, bind to local device, create QP */
- if (rdma_create_id(g_cm_events, &cm_id, (void*)conn)) {
+ if (rdma_create_id(g_cm_events, &cm_id, (void*)conn, RDMA_PS_TCP)) {
dapl_os_free(conn, sizeof(*conn));
return(dapl_convert_errno(errno, "create_qp"));
}
More information about the general
mailing list