[openib-general] Re: RE: [PATCH] osm: Adding revision empty file

Michael S. Tsirkin mst at mellanox.co.il
Wed Mar 1 08:16:40 PST 2006


Quoting r. Sasha Khapyorsky <sashak at voltaire.com>:
> Subject: Re: RE: [PATCH] osm:  Adding revision empty file
> 
> On 16:50 Wed 01 Mar     , Ofer Gigi wrote:
> >
> > To reproduce:
> > 
> > 	cd src/userspace/management/osm
> > 	./autogen.sh
> > 	./configure --disable-libcheck
> > 	make dist
> 
> Hal, Ofer, do we need distributible osm_svn_revision.h? If not we may just 
> remove it from dist and dep lists. If yes then probably we may move
> osm_svn_revision.h generation to include/Makefile.am.
> 
> To add autogenerated file under source control is not good idea.
> 
> Sasha.

We do need it. Maybe move the header to objdir?

-- 
Michael S. Tsirkin
Staff Engineer, Mellanox Technologies



More information about the general mailing list