[openib-general] Re: [PATCH] RFC Verbs: add support for transport specific verbs
Michael S. Tsirkin
mst at mellanox.co.il
Wed Mar 1 09:28:22 PST 2006
Quoting Roland Dreier <rdreier at cisco.com>:
> Subject: Re: [PATCH] RFC Verbs: add support for transport specific verbs
>
> Michael> I agree. Roland, what you might have missed is that the
> Michael> first solution posted added a requirement to check device
> Michael> type *in addition to checking the method is non-NULL and
> Michael> its return code* on each transport-specific call, so it
> Michael> had run-time penalty.
>
> I don't think I really agree with you that the device type checks are
> necessary in most places. For example, if we reach code that wants to
> call the process_mad method, then we must already know that we're
> dealing with an IB device.
Sure. But still. There's already discussion in this thread on moving multicast
stuff to ib-specific until iwarp defines it.
--
Michael S. Tsirkin
Staff Engineer, Mellanox Technologies
More information about the general
mailing list