[openib-general] Re: [PATCH 1 of 2] static rate encoding change (kernel)

Sean Hefty mshefty at ichips.intel.com
Thu Mar 2 09:50:59 PST 2006


Jack Morgenstein wrote:
> For static rate encoding, use encoding rate field from PathRecord,
> with addition of value 0, for backwards compatibility with
> current usage.
> 
> Push translation of static rate to IPD value down to provider layer.

Patch looks fine to me, with a couple of nits below.

> +enum ib_max_static_rate {
> +	IB_MAX_STATIC_RATE_PORT_CURRENT_MAX = 0,

maybe just name this IB_MAX_STATIC_RATE

> +static inline int ib_static_rate_enum_to_int(enum ib_max_static_rate rate)

Can we find a shorter/more descriptive name for this routine?

- Sean



More information about the general mailing list