[openib-general] Re: [PATCH 1 of 2] static rate encoding change (kernel)

[Michael S. Tsirkin]

Quoting r. Roland Dreier <rdreier at cisco.com>:
> Subject: Re: [PATCH 1 of 2] static rate encoding change (kernel)
> 
>  > +enum ib_max_static_rate {
>  > +	IB_MAX_STATIC_RATE_PORT_CURRENT_MAX = 0,
>  > +	IB_MAX_STATIC_RATE_2_5_GBPS = 2,
>  > +	IB_MAX_STATIC_RATE_5_GBPS   = 5,
>  > +	IB_MAX_STATIC_RATE_10_GBPS  = 3,
>  > +	IB_MAX_STATIC_RATE_20_GBPS  = 6,
>  > +	IB_MAX_STATIC_RATE_30_GBPS  = 4,
>  > +	IB_MAX_STATIC_RATE_40_GBPS  = 7,
>  > +	IB_MAX_STATIC_RATE_60_GBPS  = 8,
>  > +	IB_MAX_STATIC_RATE_80_GBPS  = 9,
>  > +	IB_MAX_STATIC_RATE_120_GBPS = 10
>  > +};
> 
> How about calling this something like ib_link_rate (ib_rate seems a
> little too short)?  The idea is that it represents the value from an
> SA query, so it would make sense to match the name of the field in the
> path record, which isn't about static rate.

ib_max_link_rate then?
The point is that we cant force the actual rate at which the connection
works, but we can set the top limit to avoid back-pressure along the path, 
so its the maximum rate, not the actual rate.

Fine with everyone?

-- 
Michael S. Tsirkin
Staff Engineer, Mellanox Technologies