[openib-general] SRP compile warning in Branch 1.0
Bob Woodruff
robert.j.woodruff at intel.com
Thu Mar 2 15:25:09 PST 2006
Ira wrote,
>/tftpboot/weiny2/openib/openib-modules/openib/infiniband/ulp/srp/ib_srp.c:
In
>function `srp_add_target':
>/tftpboot/weiny2/openib/openib-modules/openib/infiniband/ulp/srp/ib_srp.c:1
263: >warning: passing arg 1 of `scsi_scan_target' from incompatible pointer
type
>Checking this out resulted in:
>ib_srp.c:
> /* XXX: are we supposed to have a definition of SCAN_WILD_CARD ?? */
> scsi_scan_target(&target->scsi_host->shost_gendev,
> 0, target->scsi_id, ~0, 0);
>scsi_host.h:
> void scsi_scan_target(struct Scsi_Host *shost, unsigned int channel,
> unsigned int id, unsigned int lun, int rescan)
>Indeed it looks like shost_gendev (struct device) is wrong.
>Did I miss something?
>Thanks,
>Ira
I am not sure the backport for SRP is completely correct.
I have never tested it as I don't have a target or time to test it
right now. If the SRP experts could take a look at it, that would be great.
woody
More information about the general
mailing list